Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass catalog when estimating query cost #28410

Merged
merged 2 commits into from
May 10, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

The backend for query cost estimation was set to receive the query catalog, but the frontend was not passing it. This fixes it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/M and removed size/XS labels May 9, 2024
@betodealmeida betodealmeida marked this pull request as ready for review May 9, 2024 17:29
@betodealmeida betodealmeida merged commit 498c608 into master May 10, 2024
32 of 52 checks passed
imancrsrk pushed a commit to imancrsrk/superset that referenced this pull request May 10, 2024
@rusackas rusackas deleted the query-cost-estimation-catalog branch May 11, 2024 16:38
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants