Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): links corrected #28333

Merged
merged 2 commits into from
May 3, 2024
Merged

fix(website): links corrected #28333

merged 2 commits into from
May 3, 2024

Conversation

frankzimper
Copy link
Contributor

SUMMARY

Links did either 404 or linking in a circle

TESTING INSTRUCTIONS

Check changed links working properly now

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label May 3, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@john-bodley john-bodley merged commit 517f254 into apache:master May 3, 2024
29 of 30 checks passed
dpgaspar pushed a commit to preset-io/superset that referenced this pull request May 6, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.52%. Comparing base (76d897e) to head (4ad8354).
Report is 1094 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28333      +/-   ##
==========================================
+ Coverage   60.48%   60.52%   +0.03%     
==========================================
  Files        1931     1931              
  Lines       76236    76163      -73     
  Branches     8568     8566       -2     
==========================================
- Hits        46114    46100      -14     
+ Misses      28017    27959      -58     
+ Partials     2105     2104       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants