Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dremio alias #28222

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: Dremio alias #28222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/db_engine_specs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def get_available_engine_specs() -> dict[type[BaseEngineSpec], set[str]]:
try:
dialect = ep.load()
except Exception as ex: # pylint: disable=broad-except
logger.warning("Unable to load SQLAlchemy dialect %s: %s", dialect, ex)
logger.warning("Unable to load SQLAlchemy dialect %s: %s", ep.name, ex)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When ep.load() failed on line 155 this would show the name of the previous dialect successfully loaded.

else:
backend = dialect.name
if isinstance(backend, bytes):
Expand Down
7 changes: 7 additions & 0 deletions superset/db_engine_specs/dremio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@
class DremioEngineSpec(BaseEngineSpec):
engine = "dremio"
engine_name = "Dremio"
engine_aliases = {"dremio+flight"}
sqlalchemy_uri_placeholder = (
"dremio+flight://data.dremio.cloud:443/?"
"Token=<TOKEN>&"
"UseEncryption=true&"
"disableCertificateVerification=true"
)

_time_grain_expressions = {
None: "{col}",
Expand Down
Loading