fix: Rename legacy line and area charts

[john-bodley]

SUMMARY

Prior to the enablement of the generic chart x-axis, the relevant ECharts charts included the "Time-series" prefix whereas several of the deprecated NVD3 charts didn't:

After the enablement the "Time-series" prefix was correctly dropped from the ECharts charts (to reflect their more general form),

however this resulted in a somewhat of a convoluted UX, i.e., the legacy NVD3 charts only work when the x-axis is a time-series (temporal) and thus I thought the names should be updated to reflect this.

This PR renames the following NVD3 chart types:

• Area Chart (legacy) → Time-series Area Chart (legacy)
• Line Chart (legacy) → Time-series Line Chart (legacy)

It's worth noting that the the legacy NVD3 temporal bar chart was already named appropriately given it needed to distinguish itself from the legacy NVD3 non-temporal bar chart.

Finally I haven't changed any of the translations, but the keys have been updated so translations will still exist even though the don't include the Time-series prefix. I looked into updating these via Google Translate, but I'm not entirely sure how accurate they are.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

/testenv up

[github-actions]

@john-bodley Ephemeral environment spinning up at http://18.237.90.157:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

@michael-s-molina would you mind taking a look at this? Note it's listed as a chore, but I'm not certain whether in fact it would be considered a fix for 4.0 given it ensures parity with how other legacy NVD3 charts are named within the generic chart x-axis realm.

I think you can consider this as a fix.

[rusackas]

{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 2623 seconds.', code='throttled')}{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 0 seconds.', code='throttled')}{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 978 seconds.', code='throttled')}{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 3599 seconds.', code='throttled')}{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 3599 seconds.', code='throttled')}{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 3598 seconds.', code='throttled')}

Ruh Roh.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (76d897e) to head (1aa4bb7).
Report is 1094 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #28113      +/-   ##
==========================================
+ Coverage   60.48%   70.04%   +9.55%     
==========================================
  Files        1931     1933       +2     
  Lines       76236    76491     +255     
  Branches     8568     8566       -2     
==========================================
+ Hits        46114    53578    +7464     
+ Misses      28017    20809    -7208     
+ Partials     2105     2104       -1     

Flag	Coverage Δ
hive	49.21% <ø> (+0.04%)	⬆️
javascript	57.72% <ø> (+0.01%)	⬆️
mysql	77.54% <ø> (?)
postgres	77.67% <ø> (?)
presto	53.83% <ø> (+0.03%)	⬆️
python	83.26% <ø> (+19.78%)	⬆️
sqlite	77.14% <ø> (?)
unit	57.72% <ø> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[john-bodley]

@rusackas as a code owner would you mind reviewing this change?

[rusackas]

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.