-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Incorrect onChange value when an unloaded value is pasted into AsyncSelect #27996
Merged
michael-s-molina
merged 1 commit into
apache:master
from
michael-s-molina:fix-select-paste
Apr 12, 2024
Merged
fix: Incorrect onChange value when an unloaded value is pasted into AsyncSelect #27996
michael-s-molina
merged 1 commit into
apache:master
from
michael-s-molina:fix-select-paste
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpark
approved these changes
Apr 11, 2024
kgabryje
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
michael-s-molina
added
v4.0
Label added by the release manager to track PRs to be included in the 4.0 branch
v3.1
Label added by the release manager to track PRs to be included in the 3.1 branch
labels
Apr 15, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
Apr 15, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
mistercrunch
added
🍒 3.1.3
🍒 4.0.1
🍒 4.0.2
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
labels
Jul 2, 2024
irublev
pushed a commit
to HighviewPower/superset
that referenced
this pull request
Oct 29, 2024
…syncSelect (apache#27996) (cherry picked from commit 8dfdc07)
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
size/M
v3.1
Label added by the release manager to track PRs to be included in the 3.1 branch
v4.0
Label added by the release manager to track PRs to be included in the 4.0 branch
🍒 3.1.3
🍒 4.0.1
🍒 4.0.2
🚢 4.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a bug where the
onChange
event was being fired with an incorrect value when pasting a text that corresponds to an existing option in the database, which was not loaded previously due to pagination.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-04-11.at.15.24.01.mov
Screen.Recording.2024-04-11.at.15.23.18.mov
TESTING INSTRUCTIONS
1 - Use an async select that has enough values to trigger pagination. You can also reduce the Select's default page size to test.
2 - Paste a value that is not loaded yet by the Select component
3 - Check that the
onChange
event is called with the correct value. It's easier to check this when the options have numeric values. In that case,onChange
should receive the numeric value instead of the pasted text as the value property.ADDITIONAL INFORMATION