Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): updating alerts & reports documentation WEBDRIVER_BASEURL settings for docker compose #27951

Merged
merged 4 commits into from
May 15, 2024

Conversation

fisjac
Copy link
Contributor

@fisjac fisjac commented Apr 9, 2024

SUMMARY

The existing documentation for enabling a headless webdriver do not work for the environment when using docker compose. Updating the docs to suggest using WEBDRIVER_BASEURL = "https://superset_app:8088" when running in docker compose.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Apr 9, 2024
@fisjac fisjac force-pushed the webdriver-docs-update branch from e081f19 to bec5847 Compare April 9, 2024 15:04
@pull-request-size pull-request-size bot added size/XS and removed size/M labels Apr 9, 2024
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Apr 9, 2024
@john-bodley john-bodley requested a review from sfirke April 9, 2024 17:19
@mistercrunch
Copy link
Member

@fisjac fisjac force-pushed the webdriver-docs-update branch from a288b72 to 47f6500 Compare May 14, 2024 16:48
@mistercrunch mistercrunch merged commit f420005 into apache:master May 15, 2024
31 checks passed
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label May 23, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
…L settings for docker compose (apache#27951)

Co-authored-by: Evan Rusackas <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants