-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): updating alerts & reports documentation WEBDRIVER_BASEURL settings for docker compose #27951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisjac
force-pushed
the
webdriver-docs-update
branch
from
April 9, 2024 15:04
e081f19
to
bec5847
Compare
john-bodley
added
the
review:checkpoint
Last PR reviewed during the daily review standup
label
Apr 9, 2024
john-bodley
reviewed
Apr 9, 2024
What about changing it here? -> https://github.com/apache/superset/blob/master/docker/pythonpath_dev/superset_config.py#L97-L99 |
fisjac
force-pushed
the
webdriver-docs-update
branch
from
May 14, 2024 16:48
a288b72
to
47f6500
Compare
rusackas
reviewed
May 14, 2024
Co-authored-by: Evan Rusackas <[email protected]>
mistercrunch
approved these changes
May 15, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
…L settings for docker compose (apache#27951) Co-authored-by: Evan Rusackas <[email protected]>
john-bodley
removed
the
review:checkpoint
Last PR reviewed during the daily review standup
label
May 23, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
…L settings for docker compose (apache#27951) Co-authored-by: Evan Rusackas <[email protected]>
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
…L settings for docker compose (apache#27951) Co-authored-by: Evan Rusackas <[email protected]>
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 4.1.0
labels
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The existing documentation for enabling a headless webdriver do not work for the environment when using docker compose. Updating the docs to suggest using WEBDRIVER_BASEURL = "https://superset_app:8088" when running in docker compose.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION