fix: docker-release GHA fails with pathspec error #27925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
mistercrunch
force-pushed
the
fix_release_docker
branch
from
9783620 to
8cabe66
Compare
michael-s-molina
approved these changes
Apr 8, 2024
eschutho
approved these changes
Apr 8, 2024
|
@mistercrunch I was able to successfully run Docker Publish Release after merging this PR but for some reason it didn't update Docker Hub with the ARM version. Am I missing any step? |
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
Apr 15, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixing error reported here #27378 (comment) where the GHA for building docker release is unable to
git checkoutthe git-ref provided. This PR changes the fetch-depth to 0, effectively doing a full clone of the repo as opposed to a shallow clone.I'm unclear on why this stopped working as I used it many times successfully in the past.
The code here was tested with the following command:
Executing here:
https://github.com/apache/superset/actions/runs/8575368927