chore: remove fixed psycopg2 version #27907
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -155,7 +155,7 @@ connect to those datasources in your Superset installation: | |||
| ```yaml | |||
| bootstrapScript: | | |||
| #!/bin/bash | |||
| pip install psycopg2==2.9.6 \ | |||
| pip install psycopg2==2.9.9 \ | |||
There was a problem hiding this comment.
this should probably reference the optional dependencies as inpip install -e .[postgres], which would make it consistent and in sync with the ranges defined in pyproject.toml
pyproject.toml
Outdated
| @@ -150,7 +150,7 @@ ocient = [ | |||
| oracle = ["cx-Oracle>8.0.0, <8.1"] | |||
| pinot = ["pinotdb>=0.3.3, <0.4"] | |||
| playwright = ["playwright>=1.37.0, <2"] | |||
| postgres = ["psycopg2-binary==2.9.6"] | |||
| postgres = ["psycopg2-binary==2.9.9"] | |||
There was a problem hiding this comment.
Personally I'd vote for leaving this open as in psycopg2-binary>=2.9.6
There was a problem hiding this comment.
what about
psycopg2-binary>=2.9.6,<2.10 ?
since postgres is the most famous backend for superset itself
and also cause superset do not associate constraint files with release
so I don't want to be the guy that make fail future installation in case of breaking change on psycopg2 ( that is very unlikely cause psycopg3 is already out, but we never know )
There was a problem hiding this comment.
Requirements are ideally intervals rather than specific versions—which will get pinned for CI et al. when you run pip-compile-multi. The concern with pinning a version here is it could severely reduce the feasibly space when pip-compile-multi tries to freeze all packages.
There was a problem hiding this comment.
I don't understand your message @john-bodley , what are you talking about ?
|
Curious on the motives for the bump, just common hygiene or is there an issue / bug with 2.9.6? Generally I like to have code comments when we put an upper bound or a pin on a version so that we know what was keeping us from upgrading when the bound was set. |
|
hey , thanks for the review 2.9.9 support python 3.12 , so it's a first step on superset 3.12 support |
|
About python support, I wrote this recently, kind of a request for comment around the topic #27906 |
|
@raphaelauv could you please complete the PR description? This helps to provide the necessary context to the reviewers. |
SUMMARY
bump psycopg2allow upper versions of psycopg2