chore(AlteredSliceTag): Migrate to functional #27891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtexelm
force-pushed
the
chore/grit-migration/AlteredSliceTag
branch
from
672e123 to
54fbefd
Compare
|
/testenv up |
|
@eschutho Ephemeral environment spinning up at http://34.221.90.24:8080. Credentials are |
kgabryje
reviewed
Apr 17, 2024
kgabryje
reviewed
Apr 17, 2024
kgabryje
reviewed
Apr 17, 2024
kgabryje
reviewed
Apr 17, 2024
kgabryje
reviewed
Apr 17, 2024
kgabryje
reviewed
Apr 17, 2024
kgabryje
reviewed
Apr 17, 2024
kgabryje
reviewed
Apr 17, 2024
kgabryje
reviewed
Apr 17, 2024
kgabryje
reviewed
Apr 17, 2024
|
|
||
| it('correctly formats filters with string values', () => { |
There was a problem hiding this comment.
Could we add tests for specific controls like this one? I don't see them in the refactored tests and I think they're valuable
There was a problem hiding this comment.
This was actually being handled but only for string filters by the AdhocFilter test. It was pretty abstract so I made it more explicit in the revision
rtexelm
force-pushed
the
chore/grit-migration/AlteredSliceTag
branch
from
54fbefd to
eae1e1d
Compare
eschutho
approved these changes
Apr 30, 2024
|
Ephemeral environment shutdown and build artifacts deleted. |
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
Co-authored-by: Elizabeth Thompson <[email protected]>
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Elizabeth Thompson <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Refactor component to functional and update tests
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION