Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skips Hive tests that are blocking PRs #27605

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: Skips Hive tests that are blocking PRs #27605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions tests/integration_tests/charts/data/api_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@
from tests.common.query_context_generator import ANNOTATION_LAYERS
from tests.integration_tests.fixtures.query_context import get_query_context

from tests.integration_tests.test_app import app


CHART_DATA_URI = "api/v1/chart/data"
CHARTS_FIXTURE_COUNT = 10
Expand All @@ -79,6 +81,13 @@
}


@pytest.fixture(autouse=True)
def skip_by_backend():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if skip_hive (or similar) would be a more descriptive name?

with app.app_context():
if backend() == "hive":
pytest.skip("Skipping tests for Hive backend")


class BaseTestChartDataApi(SupersetTestCase):
query_context_payload_template = None

Expand Down Expand Up @@ -450,9 +459,6 @@ def test_chart_data_applied_time_extras(self):
"""
Chart data API: Test chart data query with applied time extras
"""
if backend() == "hive":
return

self.query_context_payload["queries"][0]["applied_time_extras"] = {
"__time_range": "100 years ago : now",
"__time_origin": "now",
Expand Down Expand Up @@ -751,9 +757,6 @@ def test_chart_data_async_results_type(self):
"""
Chart data API: Test chart data query non-JSON format (async)
"""
if backend() == "hive":
return

app._got_first_request = False
async_query_manager_factory.init_app(app)
self.query_context_payload["result_type"] = "results"
Expand Down
Loading