Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): organizing example chart yaml files into dashboard folders #27572

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

This is a small change before adding more example dashboards. There are a ton of charts in our examples, and this puts them in folders according to dashboard title. FWIW, the folders, and even the titles of files, are arbitrary

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Spin up an ephemeral, confirm examples work :)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas changed the title chore(examples): folderizing chart assets by dashboard chore(examples): organizing example chart yaml files into dashboard folders Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.81%. Comparing base (6e52842) to head (6f5dac4).
Report is 1389 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27572      +/-   ##
==========================================
- Coverage   69.81%   69.81%   -0.01%     
==========================================
  Files        1910     1910              
  Lines       74812    74793      -19     
  Branches     8346     8339       -7     
==========================================
- Hits        52233    52217      -16     
+ Misses      20527    20525       -2     
+ Partials     2052     2051       -1     
Flag Coverage Δ
hive 48.99% <ø> (ø)
mysql 78.02% <ø> (ø)
postgres 78.14% <ø> (ø)
presto 53.72% <ø> (ø)
python 83.15% <ø> (ø)
sqlite 77.57% <ø> (ø)
unit 56.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas requested a review from betodealmeida March 19, 2024 17:47
@rusackas
Copy link
Member Author

/testenv up

Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.218.98.238:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas force-pushed the folderizing-charts branch 2 times, most recently from 79637cd to 581e09a Compare March 20, 2024 17:58
@rusackas rusackas closed this Mar 20, 2024
@rusackas rusackas reopened this Mar 20, 2024
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas force-pushed the folderizing-charts branch from 581e09a to dfddb62 Compare March 20, 2024 21:06
@rusackas rusackas force-pushed the folderizing-charts branch from dfddb62 to 6f5dac4 Compare March 21, 2024 19:07
@rusackas
Copy link
Member Author

/testenv up

Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.201.216.224:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit a47469f into master Mar 22, 2024
37 checks passed
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas deleted the folderizing-charts branch March 22, 2024 05:13
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
@rusackas rusackas restored the folderizing-charts branch April 17, 2024 16:02
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants