-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Missing SQL Lab permission #27361
Merged
michael-s-molina
merged 2 commits into
apache:master
from
michael-s-molina:fix-missing-permission
Mar 1, 2024
Merged
fix: Missing SQL Lab permission #27361
michael-s-molina
merged 2 commits into
apache:master
from
michael-s-molina:fix-missing-permission
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27361 +/- ##
=======================================
Coverage 69.72% 69.72%
=======================================
Files 1908 1908
Lines 74550 74551 +1
Branches 8317 8317
=======================================
+ Hits 51982 51983 +1
Misses 20515 20515
Partials 2053 2053
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dpgaspar
approved these changes
Mar 1, 2024
michael-s-molina
added
the
v4.0
Label added by the release manager to track PRs to be included in the 4.0 branch
label
Mar 4, 2024
michael-s-molina
added a commit
that referenced
this pull request
Mar 4, 2024
(cherry picked from commit 8a46694)
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🍒 4.0.0
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
labels
Apr 17, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
irublev
pushed a commit
to HighviewPower/superset
that referenced
this pull request
Oct 29, 2024
(cherry picked from commit e5b588a)
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#27117 removed the following deprecated endpoint:
Which was registered in Superset's initialization:
superset init
uses the registered views to dynamically generate the permissions, in that case,can_sqllab
was generated from that entry and it does not exist anymore in a fresh installation of Superset. Searching for can_sqllab we can still find many references to it in the codebase, including the menu item that is missing. This PR adds that permission back using custom permissions.I also did a diff between 3.1 and 4.0 and found that the following permissions were removed:
The only permission that is still referenced in the codebase is
can_sqllab
.Fixes #27310
TESTING INSTRUCTIONS
Check that the
SQL query
option appears in the global + menu.ADDITIONAL INFORMATION