Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Chart Annotation modal): Table and Superset annotation options will paginate, exceeding previous max limit 100 #27022

Merged
merged 26 commits into from
Mar 26, 2024
Merged

fix(Chart Annotation modal): Table and Superset annotation options will paginate, exceeding previous max limit 100 #27022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e39e686
Edit A-Layer work for ephemeral test
rtexelm Dec 15, 2023
60eed46
Fix eslint errors
rtexelm Feb 6, 2024
811b214
Edit valueOptions to object
rtexelm Feb 21, 2024
4e59468
Fix fetchAppliedChart logic, value type, is working
rtexelm Feb 21, 2024
479ddad
Cleanse comments
rtexelm Feb 21, 2024
468d105
Fix eslint errors
rtexelm Feb 21, 2024
e9021eb
Fix eslint error
rtexelm Feb 21, 2024
a4ca342
Edit asyncfetch, handlevalue, fetchappliedchart
rtexelm Feb 22, 2024
b01d5c0
Split handleValue, fix render glitch, clean
rtexelm Feb 22, 2024
87d7b7e
Add test for fetchAppliedChart call via a fetchMock
rtexelm Feb 23, 2024
0909159
Add or modify tests
rtexelm Feb 23, 2024
8915a6c
Modify flaky test
rtexelm Feb 27, 2024
12073d2
Rename arg to avoid eslint error
rtexelm Feb 28, 2024
8141dc0
Edit func name, apply default placeholder
rtexelm Feb 29, 2024
3a036c7
Split functions, add new fetches, add search
rtexelm Mar 12, 2024
1d5c459
Reduce fetched columns, separate slice fetch, change valueOptions
rtexelm Mar 13, 2024
7438cba
Fix check for lifecycle change, fix test
rtexelm Mar 13, 2024
5be758b
Remove unnecessary return, remove initial state valueOptions
rtexelm Mar 13, 2024
f3067e4
Correct mistaken state deletion
rtexelm Mar 14, 2024
b50bbd8
Refactor query for slice and appliedChart
rtexelm Mar 23, 2024
db04251
Remove valueOptions initilization
rtexelm Mar 23, 2024
3b42b48
Init valueOptions in state again, fix tests
rtexelm Mar 25, 2024
eb2809e
Refactor valueOptions again
rtexelm Mar 25, 2024
d14639e
Refactor to remove valueOptions, handle value object in state
rtexelm Mar 25, 2024
a30cc7c
Add comment
rtexelm Mar 25, 2024
e448a3e
Fix applied value
rtexelm Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading