Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): adding code owners for translation and country map wor… #27000

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Feb 3, 2024

…kflows

SUMMARY

Adding code owners since both of these areas tend to be contributed to in the wrong way (e.g. adding random geojson files without updating the notebook, or adding .json translations rather than .po translations). This should keep things on the rails a little better, I hope. Add your name if you want!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member Author

rusackas commented Feb 3, 2024

CC @michael-s-molina and @villebro since I'm signing you up here. Feel free to nominate others ;)

@rusackas rusackas merged commit edecf52 into master Feb 5, 2024
28 of 29 checks passed
@rusackas rusackas deleted the map-and-translation-code-owners branch February 5, 2024 18:07
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants