Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump @types/jest from 26.0.24 to 29.5.12 in /superset-frontend/plugins/plugin-chart-handlebars #26973

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2024

Bumps @types/jest from 26.0.24 to 29.5.12.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@rusackas
Copy link
Member

rusackas commented Feb 1, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/superset-frontend/plugins/plugin-chart-handlebars/types/jest-29.5.12 branch from 1554524 to 627749a Compare February 1, 2024 22:52
@rusackas
Copy link
Member

rusackas commented Feb 6, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/superset-frontend/plugins/plugin-chart-handlebars/types/jest-29.5.12 branch from 627749a to eb5d036 Compare February 6, 2024 17:37
@rusackas
Copy link
Member

rusackas commented Feb 6, 2024

@mistercrunch that package lock pusher action I made sometimes works but fails on other PRs with a 403 (like this one). It's driving me crazy... maybe we can take a look at this sometime and see if I'm missing something obvious. Rebasing to see if it randomly. works this time.

@mistercrunch
Copy link
Member

@dependabot rebase

Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 26.0.24 to 29.5.12.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

---
updated-dependencies:
- dependency-name: "@types/jest"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/superset-frontend/plugins/plugin-chart-handlebars/types/jest-29.5.12 branch from eb5d036 to 317b685 Compare February 7, 2024 20:57
@mistercrunch
Copy link
Member

@rusackas
Copy link
Member

rusackas commented Feb 7, 2024

Captured a failure here https://github.com/apache/superset/actions/runs/7821052832/job/21337165609 -> Screenshot 2024-02-07 at 1 01 45 PM

This is exactly what I'm baffled by... not sure why it's getting a 403, when it's successfully pushed to other dependabot PRs. I'm a bit stumped.

@mistercrunch
Copy link
Member

mistercrunch commented Feb 7, 2024

Digging deeper, guessing it's the git push that fails
Screenshot 2024-02-07 at 1 08 30 PM, but only some of the times, confirmed by looking at the history here -> https://github.com/apache/superset/actions/workflows/update-monorepo-lockfiles.yml?page=2

@mistercrunch
Copy link
Member

oh look at that it went through this time... @rusackas I added a feature here -> https://github.com/apache/superset/pull/26973/files#diff-99ecdc2c4f7ea469fd918cc6f7dcac4cd0c6e8fb12072458bc08242947fc5d34R22 that allows us to write a comment with just @supersetbot trigger-dependabot-lockfile to re-run just that one step and not all the other CI events that happen on-pull-request

@mistercrunch
Copy link
Member

I'd attribute the issue here as some sort of inconsistency/issue with GitHub action infrastructure as I can't think of anything else. Hopefully gets tackled. In the meantime, we should be able to comment @supersetbot trigger-dependabot-lockfile to retrigger only this one thing until we get lucky.

@supersetbot trigger-dependabot-lockfile also sets a precedent as to how to force-run or force-rerun a CI step. Seem like it could be a useful pattern if/when we push it to the next level.

@mistercrunch
Copy link
Member

oh btw every job now is waiting, as if CI didn't get triggered (?)
Screenshot 2024-02-07 at 1 43 43 PM

@mistercrunch
Copy link
Member

let's assume this was a random hiccup and close/re-open to trigger...

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 7, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@mistercrunch mistercrunch reopened this Feb 7, 2024
@rusackas
Copy link
Member

rusackas commented Feb 7, 2024

Thanks for jumping into the fray once again :)

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (686ce33) 69.51% compared to head (223786d) 69.51%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26973   +/-   ##
=======================================
  Coverage   69.51%   69.51%           
=======================================
  Files        1899     1899           
  Lines       74369    74369           
  Branches     8274     8274           
=======================================
  Hits        51700    51700           
  Misses      20614    20614           
  Partials     2055     2055           
Flag Coverage Δ
javascript 56.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch mistercrunch merged commit daaf657 into master Feb 7, 2024
35 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/superset-frontend/plugins/plugin-chart-handlebars/types/jest-29.5.12 branch February 7, 2024 22:36
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
…t-frontend/plugins/plugin-chart-handlebars (apache#26973)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Maxime Beauchemin <[email protected]>
Co-authored-by: GitHub-Actions[bot] <github-actions[bot]@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
…t-frontend/plugins/plugin-chart-handlebars (apache#26973)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Maxime Beauchemin <[email protected]>
Co-authored-by: GitHub-Actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dependabot dependencies:npm npm Dependabot - npm related PRs size/S 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants