Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Period over Period Big Number comparison chart #26908

Merged
merged 7 commits into from
Jan 31, 2024

Apply suggestions from code review

2ac04ea
Select commit
Loading
Failed to load commit list.
Merged

feat: Period over Period Big Number comparison chart #26908

Apply suggestions from code review
2ac04ea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 31, 2024 in 0s

69.51% (+2.21%) compared to d8f7e2c

View this Pull Request on Codecov

69.51% (+2.21%) compared to d8f7e2c

Details

Codecov Report

Attention: 138 lines in your changes are missing coverage. Please review.

Comparison is base (d8f7e2c) 67.29% compared to head (2ac04ea) 69.51%.
Report is 10 commits behind head on master.

Files Patch % Lines
...rt-period-over-period-kpi/src/plugin/buildQuery.ts 0.00% 99 Missing ⚠️
...eriod-over-period-kpi/src/plugin/transformProps.ts 3.70% 26 Missing ⚠️
...plugin-chart-period-over-period-kpi/src/PopKPI.tsx 0.00% 10 Missing ⚠️
...n-chart-period-over-period-kpi/src/plugin/index.ts 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #26908      +/-   ##
==========================================
+ Coverage   67.29%   69.51%   +2.21%     
==========================================
  Files        1895     1900       +5     
  Lines       74249    74347      +98     
  Branches     8257     8264       +7     
==========================================
+ Hits        49968    51680    +1712     
+ Misses      22206    20618    -1588     
+ Partials     2075     2049      -26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov