chore(dependabot): auto-update lockfiles for monorepo package bumps #26872
Conversation
rusackas
requested review from
villebro,
geido,
eschutho,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
There was a problem hiding this comment.
This will lead to double triggering CI in cases we're trying to fix here. Meaning all pull_request events workflows trigger once, including this one, and once the push happens again, CI does a full re-trigger maybe a few minutes later. We could have all other CI tasks depend on this one, but that would delay things. I'd let's make sure this only triggers on opened and be ok with the double-trigger stuff
| - 'superset-frontend/packages/**/package.json' | ||
| - 'superset-frontend/plugins/**/package.json' | ||
| # Trigger this workflow when Dependabot creates a pull request | ||
| types: [opened, synchronize, reopened] |
There was a problem hiding this comment.
I'd say this should only trigger on opened, not the others. We don't want it to trigger itself, even though I think git push should be a no-op when the files does not change on the second run.
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
| git add package-lock.json | ||
| git commit -m "Update lock file for Dependabot PR" -a # Commit the changes | ||
| git push # Push the changes back to the branch |
There was a problem hiding this comment.
Assuming this is a no-op on the second run.
|
I approved the change I submitted 😄 |
…pache#26872) Co-authored-by: Maxime Beauchemin <[email protected]>
…pache#26872) Co-authored-by: Maxime Beauchemin <[email protected]>
mistercrunch
added
🏷️ bot
…pache#26872) Co-authored-by: Maxime Beauchemin <[email protected]>
SUMMARY
When dependabot bumps packages for monorepo packages/plugins, it doesn't work out. It bumps package.json, but it's not smart enough to know that it needs to run
npm installfrom the root of thesuperset-frontendfolder. This action will keep an eye out for these PRs from dependabot on those paths, and run the installation command, and push the package lock file.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION