-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add permission to view and drill on Dashboard context #26798
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26798 +/- ##
==========================================
+ Coverage 67.22% 69.56% +2.33%
==========================================
Files 1895 1895
Lines 74211 74232 +21
Branches 8245 8251 +6
==========================================
+ Hits 49891 51639 +1748
+ Misses 22248 20522 -1726
+ Partials 2072 2071 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to create a permission on the backend?
superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx
Outdated
Show resolved
Hide resolved
…o/ch77449/embedded_drill_permission
This reverts commit dcb882d.
…o/ch77449/embedded_drill_permission
…o/ch77449/embedded_drill_permission
…o/ch77449/embedded_drill_permission
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small nit, otherwise lgtm!
@mistercrunch @rusackas |
Hi @rohitpawar2811 if you are looking specifically for the |
hi I have all roles. And can not see drill down menu in superset graphs. Why? |
Hello @agunoglu what roles do you currently have and what version are you on? |
SUMMARY
Introducing the
can_view_and_drill
permission to enable drilling and read-only related chart interactions, such as "View as table" in Dashboard.This is particularly useful in contexts like embedded dashboards where one would not want to give the
can_explore
permission but still allow certain charts' interactions within the dashboard context.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
All tests should pass
ADDITIONAL INFORMATION