-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(translations): updating pot -> po -> json files (babel 2.9.1) #26773
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26773 +/- ##
==========================================
+ Coverage 67.17% 69.50% +2.32%
==========================================
Files 1900 1900
Lines 74443 74443
Branches 8293 8293
==========================================
+ Hits 50009 51739 +1730
+ Misses 22379 20649 -1730
Partials 2055 2055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is just a draft, but there's nothing controversial here. Feels like progress to merge this. Seems that whole flow is broken now and this fixes some of it.
Keeping this as a draft because it'll potentially overwrite a LOT of translation PRs. |
We can discuss it at Town Hall and/or Release Strategy... it might warrant a SIP or some form of consensus to make doing this something that happens at each major version release (since it can undo the work of others, which seems like a breaking change) |
2eab6f1
to
0365cc7
Compare
Pulling in some new translation work from |
Just need a codeowner approval from @michael-s-molina or @villebro and we should be good to go here. |
|
SUMMARY
Runs translation scripts (e.g. pybabel) to update .pot and .po files
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION