-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prevent CI double runs on push + pull_request #26766
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26766 +/- ##
==========================================
- Coverage 69.29% 67.16% -2.13%
==========================================
Files 1894 1894
Lines 74173 74175 +2
Branches 8243 8243
==========================================
- Hits 51396 49821 -1575
- Misses 20708 22285 +1577
Partials 2069 2069
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull_request: | ||
types: [synchronize, opened, reopened, ready_for_review] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a path here, eg:
types: [synchronize, opened, reopened, ready_for_review] | |
paths: | |
- "superset-frontend/src/**" | |
types: [synchronize, opened, reopened, ready_for_review] |
bbf811a
to
dfd9567
Compare
I ended up squeezing in more cache optimizations for docker in there as I was testing all sorts of things to speed up the builds:
|
SUMMARY
I noticed recently that we get many "double-triggers" of CI actions on some PRs, most notable on PRs opened from the main apache repo, triggering against the master branch (see screenshot bellow). This is typically one for the
push
action and one for thepull_request
action, running effectively the exact same CI script twice. Note that I think the double triggers also on forks (I'd have to double check), but just doesn't show under the PR list of required CI steps, and is probably just associated with the fork of the user.Anyhow, so I went through all the githbub workflows and applied more restrictions. In most cases we apply the main pattern:
This will trigger for each change on the pull request, and for every commit as it merges on the
master
branch.In some other cases, I added a
paths
statement where I knew we should only run a workflow given a certain obvious folder, like frontend tests should only run if we touchsuperset-frontend/**
and such.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF