chore: fix GitHub 'Unchanged files with check annotations' reports in PR

[mistercrunch]

SUMMARY

Addressing the GitHub-reported lint warnings that show up in every PR. It's unclear to me why those warnings are surfaced by not others, but let's silence those clean up future PR from this. Note that there are 255 other warnings that are not surfaced in PRs, wondering if they do some sort of top N (?). We'll know soon enough.

Related issue filed with GitHub about this annoying beta feature -> actions/toolkit#457

[mistercrunch]

removing the . at the end so this private base command can be reused more generically

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f59079) 67.16% compared to head (5b2bab7) 67.16%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26702      +/-   ##
==========================================
- Coverage   67.16%   67.16%   -0.01%     
==========================================
  Files        1894     1894              
  Lines       74175    74175              
  Branches     8243     8243              
==========================================
- Hits        49821    49818       -3     
- Misses      22285    22288       +3     
  Partials     2069     2069              

Flag	Coverage Δ
javascript	56.86% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mistercrunch]

Oh it looks like the "Unchanged files with check annotations" is reporting some top N of eslint warnings, not this particular subset I tackled in this PR, which there are 268 at this time.

[mistercrunch]

I'm going to lookup a way to shut off the stupid unrelated lint warnings as I really don't think they help. We know we have lint warning, and they really don't help in the context of an unrelated PR.

[mistercrunch]

Commented here, going to look and see if there's a way to run eslint with no-warnings in CI

[mistercrunch]

I think prior PR fixed #26704 the reporting of these, with --quiet now properly taking effect as it's passed to eslint, not tsc like it was before. Let's enjoy some squeaky clean PRs with no unrelated smell warnings.

[rusackas]

Meant to review this sooner... I thought some of these estlint-disable bits might be in actual UI files files. I don't think we should be sweeping any under the rug in those cases but I don't think it's a problem in these test files.

[mistercrunch]

Yeah in the end what fixed the annoying messages in PRs was to pass a --quiet flag to eslint in the context of CI. The warnings are still very much there, just not in CI / PRs.