-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Deprecates the DASHBOARD_CROSS_FILTERS feature flag #26633
chore: Deprecates the DASHBOARD_CROSS_FILTERS feature flag #26633
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26633 +/- ##
==========================================
- Coverage 68.98% 66.85% -2.13%
==========================================
Files 1930 1930
Lines 75309 75309
Branches 8429 8429
==========================================
- Hits 51949 50345 -1604
- Misses 21213 22817 +1604
Partials 2147 2147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the rebase.
SUMMARY
As part of the 4.0 approved initiatives, this PR deprecates the
DASHBOARD_CROSS_FILTERS
feature flag which is currentlyTrue
by default. The feature is already being used in production environments and we believe it's not something admins would want to disable.TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION