Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stringify scarf pixel value #26351

Merged

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Dec 23, 2023

SUMMARY

In order to match the expression here: https://github.com/apache/superset/blob/master/superset-frontend/src/components/TelemetryPixel/index.tsx#L48
we need to cast the env var for SCARF_ANALYTICS to a string in the webpack config.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho changed the title stringify scarf pixel value fix: stringify scarf pixel value Dec 23, 2023
@eschutho eschutho marked this pull request as ready for review December 23, 2023 00:09
@eschutho eschutho requested a review from rusackas December 23, 2023 00:09
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04f1c35) 69.18% compared to head (34c15c9) 69.18%.
Report is 35 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26351   +/-   ##
=======================================
  Coverage   69.18%   69.18%           
=======================================
  Files        1945     1945           
  Lines       75967    75982   +15     
  Branches     8466     8475    +9     
=======================================
+ Hits        52556    52568   +12     
  Misses      21224    21224           
- Partials     2187     2190    +3     
Flag Coverage Δ
javascript 56.52% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

rusackas commented Jan 3, 2024

I fear this might cause as much ambiguity as it solves, but I'll do some testing to confirm...

@eschutho eschutho added the hold:testing! On hold for testing label Jan 4, 2024
@rusackas rusackas merged commit 0b20ace into apache:master Jan 16, 2024
53 of 55 checks passed
@eschutho eschutho removed the hold:testing! On hold for testing label Jan 22, 2024
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jan 26, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants