-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(releasing): adding SHA512 and RSA signature validation script to verify releases #26278
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26278 +/- ##
==========================================
+ Coverage 66.99% 69.11% +2.11%
==========================================
Files 1945 1946 +1
Lines 75949 76437 +488
Branches 8460 8707 +247
==========================================
+ Hits 50885 52830 +1945
+ Misses 22879 21392 -1487
- Partials 2185 2215 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Validating releases to check SHA-512 checksum and RSA signature against the apache KEYS file is a bit... tedious.
This adds a python script to the RELEASING folder (and documentation about it) so you can just run the script and check if the release is valid.
Once releases contain this script, you can also run a bash script or npm script to validate the release from the scripts within.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION