refactor: Ensure Flask-Migrate leverages the Flask-SQLAlchemy session #26172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--sip-99-alembic-session
branch
from
3609a02 to
8c652ff
Compare
john-bodley
changed the title
john-bodley
force-pushed
the
john-bodley--sip-99-alembic-session
branch
3 times, most recently
from
731f304 to
9ff99f8
Compare
john-bodley
force-pushed
the
john-bodley--sip-99-alembic-session
branch
from
9ff99f8 to
1b22222
Compare
john-bodley
changed the title
john-bodley
changed the title
john-bodley
changed the title
john-bodley
changed the title
9 tasks
|
Sadly I think this effort needs to be abandoned per miguelgrinberg/Flask-Migrate#534. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Somewhat related to #26186 (though for Alembic migrations) this PR ensures that the remainder of the codebase (excluding tests and Alembic migrations) leverage the Flask-SQLAlchemy session (
db.session).This refactor helps to reduce the code complexity and ensures we're not generating any rouge sessions which are often not explicitly closed and can lead to connection pooling issues.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION