chore: Clean up the examples dashboards

superset-frontend/cypress-base/cypress/e2e/dashboard/nativeFilters.test.ts

@@ -113,7 +113,7 @@ function prepareDashboardFilters(
         },
         type: 'NATIVE_FILTER',
         description: '',
-        chartsInScope: [6],
+        chartsInScope: [5],
         tabsInScope: [],
       });
     });
@@ -150,7 +150,7 @@ function prepareDashboardFilters(
             meta: {
               width: 4,
               height: 50,
-              chartId: 6,
+              chartId: 5,
               sliceName: 'Most Populated Countries',
             },
           },
@@ -414,7 +414,7 @@ describe('Native filters', () => {
       cy.createSampleDashboards([0]);
     });
 
-    it('Verify that default value is respected after revisit', () => {
+    it.only('Verify that default value is respected after revisit', () => {
       prepareDashboardFilters([
         { name: 'country_name', column: 'country_name', datasetId: 2 },
       ]);

superset-frontend/cypress-base/cypress/e2e/dashboard/tabs.test.ts

@@ -25,7 +25,6 @@ import { TABBED_DASHBOARD } from 'cypress/utils/urls';
 import { expandFilterOnLeftPanel } from './utils';
 
 const TREEMAP = { name: 'Treemap', viz: 'treemap_v2' };
-const FILTER_BOX = { name: 'Region Filter', viz: 'filter_box' };
 const LINE_CHART = { name: 'Growth Rate', viz: 'line' };
 const BOX_PLOT = { name: 'Box plot', viz: 'box_plot' };
 const BIG_NUMBER = { name: 'Number of Girls', viz: 'big_number_total' };
@@ -41,7 +40,6 @@ function topLevelTabs() {
 function resetTabs() {
   topLevelTabs();
   cy.get('@top-level-tabs').first().click();
-  waitForChartLoad(FILTER_BOX);
   waitForChartLoad(TREEMAP);
   waitForChartLoad(BIG_NUMBER);
   waitForChartLoad(TABLE);
@@ -96,7 +94,6 @@ describe('Dashboard tabs', () => {
 
   it.skip('should send new queries when tab becomes visible', () => {
     // landing in first tab
-    waitForChartLoad(FILTER_BOX);
     waitForChartLoad(TREEMAP);
 
     getChartAliasBySpec(TREEMAP).then(treemapAlias => {

superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts

@@ -23,7 +23,6 @@ import { ChartSpec, waitForChartLoad } from 'cypress/utils';
 export const WORLD_HEALTH_CHARTS = [
   { name: '% Rural', viz: 'world_map' },
   { name: 'Most Populated Countries', viz: 'table' },
-  { name: 'Region Filter', viz: 'filter_box' },
   { name: "World's Population", viz: 'big_number' },
   { name: 'Growth Rate', viz: 'line' },
   { name: 'Rural Breakdown', viz: 'sunburst' },

superset-frontend/cypress-base/cypress/support/e2e.ts

@@ -18,7 +18,7 @@
  */
 import '@cypress/code-coverage/support';
 import '@applitools/eyes-cypress/commands';
-import failOnConsoleError, { Config } from 'cypress-fail-on-console-error';
+import failOnConsoleError from 'cypress-fail-on-console-error';
 
 require('cy-verify-downloads').addCustomCommand();
 
@@ -44,8 +44,8 @@
 });
 
 const BASE_EXPLORE_URL = '/explore/?form_data=';
 let DASHBOARD_FIXTURES: Record<string, any>[] = [];
 let CHART_FIXTURES: Record<string, any>[] = [];
 
 Cypress.Commands.add('loadChartFixtures', () =>
   cy.fixture('charts.json').then(charts => {
@@ -72,7 +72,7 @@
 });
 
 Cypress.Commands.add('cleanDashboards', () => {
   cy.getDashboards().then((sampleDashboards?: Record<string, any>[]) => {
     const deletableDashboards = [];
     for (let i = 0; i < DASHBOARD_FIXTURES.length; i += 1) {
       const fixture = DASHBOARD_FIXTURES[i];
@@ -102,7 +102,7 @@
 });
 
 Cypress.Commands.add('cleanCharts', () => {
   cy.getCharts().then((sampleCharts?: Record<string, any>[]) => {
     const deletableCharts = [];
     for (let i = 0; i < CHART_FIXTURES.length; i += 1) {
       const fixture = CHART_FIXTURES[i];
@@ -306,7 +306,7 @@
 Cypress.Commands.add(
   'deleteDashboardByName',
   (dashboardName: string, failOnStatusCode = false) =>
     cy.getDashboards().then((sampleDashboards?: Record<string, any>[]) => {
       const dashboard = sampleDashboards?.find(
         d => d.dashboard_title === dashboardName,
       );
@@ -360,7 +360,7 @@
 
 Cypress.Commands.add(
   'updateDashboard',
   (dashboardId: number, body: Record<string, any>) =>
     cy
       .request({
         method: 'PUT',
@@ -406,7 +406,7 @@
 Cypress.Commands.add(
   'deleteChartByName',
   (sliceName: string, failOnStatusCode = false) =>
     cy.getCharts().then((sampleCharts?: Record<string, any>[]) => {
       const chart = sampleCharts?.find(c => c.slice_name === sliceName);
       if (chart) {
         cy.deleteChart(chart.id, failOnStatusCode);