Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): removing unused code #26137

Closed
wants to merge 1 commit into from
Closed

Conversation

rusackas
Copy link
Member

SUMMARY

If I'm not mistaken, this chunk of code was unused leftovers from #25996. Just nuking it here before anyone forgets to do so :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from hughhhh November 29, 2023 19:15
@rusackas rusackas requested a review from lilykuang November 29, 2023 19:15
@rusackas rusackas marked this pull request as ready for review November 29, 2023 19:15
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee308fb) 69.09% compared to head (f1ba6eb) 69.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26137   +/-   ##
=======================================
  Coverage   69.09%   69.10%           
=======================================
  Files        1941     1941           
  Lines       75891    75884    -7     
  Branches     8450     8448    -2     
=======================================
- Hits        52437    52436    -1     
+ Misses      21279    21273    -6     
  Partials     2175     2175           
Flag Coverage Δ
hive 53.68% <ø> (ø)
javascript 56.27% <ø> (+<0.01%) ⬆️
mysql 78.16% <ø> (+0.02%) ⬆️
postgres 78.26% <ø> (ø)
presto 53.63% <ø> (ø)
python 82.95% <ø> (-0.01%) ⬇️
sqlite 76.91% <ø> (ø)
unit 55.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hughhhh
Copy link
Member

hughhhh commented Nov 29, 2023

@rusackas this code is needed for shell at the moment once we release the cherry from the previous PR we can merge this

@rusackas rusackas closed this Nov 29, 2023
@mistercrunch mistercrunch deleted the removing-dead-code branch March 26, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants