-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(BH#109): Athena URI spec fix #26044
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26044 +/- ##
==========================================
- Coverage 69.08% 69.07% -0.02%
==========================================
Files 1941 1941
Lines 75892 75892
Branches 8443 8443
==========================================
- Hits 52431 52420 -11
- Misses 21286 21297 +11
Partials 2175 2175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - confirmed that this is the connection string Google gives + the one we have in the dedicated Athena section.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Someone reported the Athena driver being broken/cut off. I found the missing bits on Stack Overflow and I'm posting them here. Hopefully this is correct, but we would need an Athena user to test (there are none on the rolodex
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION