Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typings): model_id is a multiple option #25967

Merged
merged 4 commits into from
Dec 18, 2023
Merged

fix(typings): model_id is a multiple option #25967

merged 4 commits into from
Dec 18, 2023

Conversation

gnought
Copy link
Contributor

@gnought gnought commented Nov 13, 2023

SUMMARY

superset compute-thumbnails accepts multiple --model_id options. The model_id should be a List[int].

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley self-requested a review November 13, 2023 17:50
villebro
villebro reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup! LMKWYT about my small improvement proposal.

superset/cli/thumbnails.py Outdated
@@ -76,7 +76,7 @@ def compute_thumbnails(
def compute_generic_thumbnail(
friendly_type: str,
model_cls: Union[type[Dashboard], type[Slice]],
model_id: int,
model_id: list[int],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: For disambiguation and clarity, we may want to call the argument in the inner function model_ids.

@villebro
Copy link
Member

Let's not change the outer variable name, only the one in the inner function.

@gnought
Copy link
Contributor Author

gnought commented Nov 16, 2023

@villebro Thanks for the advise. Amended.

@john-bodley john-bodley merged commit 04f1c35 into apache:master Dec 18, 2023
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Dec 20, 2023
michael-s-molina pushed a commit that referenced this pull request Dec 27, 2023
@gnought @michael-s-molina
fix(typings): model_id is a multiple option (#25967)
d5a5d5f 
(cherry picked from commit 04f1c35)
michael-s-molina pushed a commit that referenced this pull request Dec 27, 2023
@gnought @michael-s-molina
fix(typings): model_id is a multiple option (#25967)
dd68c6e 
(cherry picked from commit 04f1c35)
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@gnought @josedev-union
fix(typings): model_id is a multiple option (apache#25967)
4407706 
(cherry picked from commit 04f1c35)
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@gnought @sfirke
fix(typings): model_id is a multiple option (apache#25967)
6ccd94b
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@gnought
fix(typings): model_id is a multiple option (apache#25967)
2d45e8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro left review comments

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🍒 3.1.2 🍒 3.1.3 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gnought @villebro @john-bodley @mistercrunch @michael-s-molina