Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table chart): Show Cell Bars correctly #25625 #25707

Merged
merged 13 commits into from
Nov 6, 2023
Merged

fix(table chart): Show Cell Bars correctly #25625 #25707

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
01a16b4
fixed the bug where the percentage cell bars were not showing
SA-Ark Oct 19, 2023
4684ccc
created a test to make sure the cell bars are showing properly on the…
SA-Ark Oct 25, 2023
f4f083b
Merge branch 'apache:master' into master
SA-Ark Oct 25, 2023
5c70b67
Update
SA-Ark Oct 25, 2023
90559f2
Merge branch 'master' into tableChartCellBarTest
SA-Ark Oct 25, 2023
4cc2a6a
Merge branch 'apache:master' into master
SA-Ark Oct 27, 2023
06e75c5
Merge remote-tracking branch 'upstream/master'
SA-Ark Oct 27, 2023
d16492f
Merge branch 'tableChartCellBarTest'
SA-Ark Oct 27, 2023
bec0850
Merge branch 'master' of github.com:SA-Ark/superset
SA-Ark Oct 27, 2023
4e64c0c
Merge branch 'apache:master' into master
SA-Ark Oct 30, 2023
a282e2c
Merge remote-tracking branch 'upstream/master'
SA-Ark Oct 30, 2023
cef71e0
lint fix
SA-Ark Oct 30, 2023
1c0a817
Merge branch 'master' of github.com:SA-Ark/superset
SA-Ark Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,15 @@ export default function TableChart<D extends DataRecord = DataRecord>(

const getColumnConfigs = useCallback(
(column: DataColumnMeta, i: number): ColumnWithLooseAccessor<D> => {
const { key, label, isNumeric, dataType, isMetric, config = {} } = column;
const {
key,
label,
isNumeric,
dataType,
isMetric,
isPercentMetric,
config = {},
} = column;
const columnWidth = Number.isNaN(Number(config.columnWidth))
? config.columnWidth
: Number(config.columnWidth);
Expand Down Expand Up @@ -438,7 +446,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
(config.showCellBars === undefined
? showCellBars
: config.showCellBars) &&
(isMetric || isRawRecords) &&
(isMetric || isRawRecords || isPercentMetric) &&
getValueRange(key, alignPositiveNegative);

let className = '';
Expand Down