fix(dashboard)!: Downgrade WTForms to >=2.3.3, <3.1.0 due to compatibility issues #25643
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dpgaspar
reviewed
Oct 23, 2023
| @@ -130,7 +130,7 @@ def get_git_sha() -> str: | |||
| "typing-extensions>=4, <5", | |||
| "waitress; sys_platform == 'win32'", | |||
| "werkzeug>=2.3.3, <3", | |||
| "wtforms>=2.3.3, <4", | |||
There was a problem hiding this comment.
This was fixed on FAB and bumped here: #25712
There was a problem hiding this comment.
Confirmed. Would it be appropriate for me to close this PR now?
There was a problem hiding this comment.
I just posted on #25631 asking them to confirm that the issue does not persist in Superset 3.0.2, which uses a newer version of FAB. Especially if someone can confirm that this issue is solved, then I would think this PR can be closed.
There was a problem hiding this comment.
I closed the other issue because of a lack of response. I'm guessing it's safe now to close this issue, but let me know if anyone disagrees!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
While installing Superset via pip, WTForms version 3.1.0 is fetched, which is incompatible. Pinning the version to 3.0.1 resolves errors on pages like 'List Users', 'Roles', and 'Activity'.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Please refer to the following issues for more screenshots and further details:
Fixes #25622
Fixes #25631
TESTING INSTRUCTIONS
pip uninstall wtforms) and reinstall the compatible version (pip install wtforms==3.0.1). The error should no longer be present when you navigate to the /users endpointAdditional Observation:
Post this update, a UI issue was observed when I ran
pip install .instead ofpip install apache-supersetas per the documentation. However, this seems unrelated to the changes in setup.py since it persists even when reverting to the original state and running the same command. Any insights into this would be appreciated.ADDITIONAL INFORMATION