-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: BugHerd Tasks 88, 89, 90, 91 #25567
Conversation
7c54f13
to
64cc844
Compare
Thanks @mdeshmu for the change. Would you mind providing links to the Bugherd tasks and additionally include a synopsis of the task so that anyone without access to Bugherd can grok what the underlying issues being resolved are. |
@john-bodley added links of the tasks and synopsis in the description |
Thanks for flagging, I will review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great additions! Content looks great, I just have some suggestions to make it read easier.
This are great additions @mdeshmu ! Only other thing: I noticed while reviewing this that the page title for https://superset.apache.org/docs/security/ is "Role based Access" - it should be "Security" probably. It's confusing to see that on the search engine results page. I'd also like to remove to the top heading that says "Roles", as that first summary paragraph should stand alone with no heading. Are you up for making those fixes while you are editing this page? |
@sfirke Those are great suggestions. I will incorporate them soon. |
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
@sfirke All requested changes are done. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these edits! Especially to the page title for Security.
Thanks @mdeshmu , this was a great addition! |
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
SUMMARY
Address BugHerd Tasks
88 - Document #23745 (comment)
89 - Document AUTH_ROLES_MAPPING https://apache-superset.slack.com/archives/C0170U650CQ/p1696514613463559
90 - Document about SUPERSET_CONFIG_PATH variable
91 - Specifying correct python version in docs for official docker image
cc: @sfirke
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION