-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): add ukranian translations #25323
feat(i18n): add ukranian translations #25323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just looked through some of the translations.
I think the word "дашборд" is good to change "панель" or "табло" or a bit different "упорядник"
Also, I found that you use 2 different words for "Chart": "Діаграма" and "Графік". I think "Діаграма" is more general and fits better
"1 hour": ["1 година"], | ||
"1 hourly frequency": ["1 погодинна частота"], | ||
"1 minute": ["1 хвилина"], | ||
"1 minutely frequency": ["1 Частотна частота"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"1 minutely frequency": ["1 Частотна частота"], | |
"1 minutely frequency": ["1 хвилинна частота"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated
"1M": ["1M"], | ||
"1T": ["1T"], | ||
"2 years": ["2 роки"], | ||
"2 years ago": ["2 роки назад"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"2 years ago": ["2 роки назад"], | |
"2 years ago": ["2 роки тому"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
"A handlebars template that is applied to the data": [ | ||
"Шаблон ручки, який застосовується до даних" | ||
], | ||
"A human-friendly name": ["Ім'я зручної для людини"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to have
"Ім'я, що зручне для людини"
Or
"Зручне для людини ім'я"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
"AXIS TITLE POSITION": ["Позиція заголовка вісь"], | ||
"About": ["Про"], | ||
"Access": ["Доступ"], | ||
"Access requests": ["Запити на доступ до доступу"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Access requests": ["Запити на доступ до доступу"], | |
"Access requests": ["Запити доступу"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this
"Add new formatter": ["Додати новий форматер"], | ||
"Add notification method": ["Додайте метод сповіщення"], | ||
"Add required control values to preview chart": [ | ||
"Додайте необхідні контрольні значення до діаграми попереднього перегляду" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Додайте необхідні контрольні значення до діаграми попереднього перегляду" | |
"Додайте необхідні контрольні значення для попереднього перегляду діаграми" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated
Thank you, I fixed Chart translations. As per “Dashboard” I am working on translating it to “Інформаційна Панель” throughout the pages. |
@mlisivka I don't speak Ukranian, can you review the PR and approve it if everything is ok? |
@michael-s-molina OK, but it will take some time for me, probably weeks. Ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It seems this PR was getting stuck, and I didn't want to lose all this value in a conflict or something. The net benefit seems very high, even if there are a few things to correct in follow-up PRs. Please do open as many PRs as you'd like to make corrections and improve the situation. |
SUMMARY
Adding initial version of the Ukrainian translations for the Superset. To translate phrases I used Google Translate, and after this manually checked most of the translations.
AFTER SCREENSHOTS
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION