-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validation errors appearing after ssh tunnel switch #24849
Conversation
fe63ee7
to
0115ef5
Compare
0115ef5
to
d2d3e22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Can we add or update some tests to include this prop?
Codecov Report
@@ Coverage Diff @@
## master #24849 +/- ##
=======================================
Coverage 68.99% 69.00%
=======================================
Files 1904 1904
Lines 74081 74108 +27
Branches 8193 8193
=======================================
+ Hits 51115 51137 +22
- Misses 20845 20850 +5
Partials 2121 2121
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
(cherry picked from commit b71541f)
(cherry picked from commit b71541f)
(cherry picked from commit b71541f)
(cherry picked from commit b71541f)
SUMMARY
fixed issues with onBlur validation callbacks when user clicks the ssh tunnel toggle. Main issue was errors were still appearing after the fact when the entire forms needs to be filled out to establish an ssh tunnel connection
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION