-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): Add docText for long keyword #24847
fix(sqllab): Add docText for long keyword #24847
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24847 +/- ##
==========================================
+ Coverage 68.99% 69.00% +0.01%
==========================================
Files 1903 1904 +1
Lines 74072 74109 +37
Branches 8193 8195 +2
==========================================
+ Hits 51107 51142 +35
- Misses 20844 20848 +4
+ Partials 2121 2119 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @justinpark. I left some first-pass comments.
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 1a9c559)
SUMMARY
Since the keyword tooltip is fixed size, a longer keyword name will be collapsed. This commit add
docText
for long keywords to enable the tooltip for the longer item.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
after--doc-text-for-long-text.mov
Before:
TESTING INSTRUCTIONS
Go to SQL Lab and enable autocomplete
Please select a schema including a long table name
ADDITIONAL INFORMATION