fix(chart): Fix bugs ‘Older Dates with Year 1937 or less in charts is showing as NAN’

[wangkun723]

SUMMARY

I made modifications in two places to try to solve the problem.The problem may be that the time data transmitted by the backend to the front-end is a timestamp, but when the length of a number timestamp number is greater than 12 (excluding symbols) when the time is less than 1937, the front-end JSON conversion will become 'BigNumber' and cannot be directly converted into formatted form.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:fixes Older Dates with Year 1937 or less in charts is showing as NAN. #24561
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[sfirke]

I can't speak to the code but appreciate you working on this!

[justinpark]

@wangkun723 it doesn't look safe to custom logic in each chart. The logic should be within dateFormatter.
I also found this PR from @villebro which seems cover this case too.
Could you try with the above hotfix?

[wangkun723]

Okay, thank you for your guidance

[wangkun723]

@justinpark Hello, I have made the code changes and placed the logic inside the TimeFormatter class. please review it again

[sfirke]

I can't replicate #24561 on 3.0.0rc2, following the same steps I use to reproduce the behavior on 2.1.0. Maybe closed by the PR that @justinpark flagged as related, #23339 ? (though #24561 wasn't Trino-specific).

@wangkun723 are you able to try out 3.0.0rc2 release candidate version or the latest version from Github and see if the original bug has already been fixed? If so then this PR could probably be closed.

[wangkun723]

我无法按照我在 2.1.0 上重现行为的相同步骤在 3.0.0rc2 上复制#24561 。也许被 PR 关闭了@justinpark标记为相关，#23339？（尽管#24561不是 Trino 特有的）。

@wangkun723您是否可以尝试 3.0.0rc2 候选版本或latest来自 Github 的版本，看看原始错误是否已修复？如果是这样，那么这个 PR 可能会被关闭。

It still exists with latest version

[rusackas]

It seems that the issue this PR was attempting to solve is no longer an issue in current versions. That's probably how this slipped under the radar for so long... it's just not needed nowadays. If anyone is still experience the bug or sees a need for this PR, just say the word, so we can reopen it and see if it passes current CI. Thanks for the contribution!