feat: Implement support for currencies in more charts

[kgabryje]

SUMMARY

Continuation of #24517.
Implements support for currencies in WorldMap, Heatmap, Sunburst and Mixed Chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Follow the instructions from #24517, verify that the feature works in listed viz types.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

@kgabryje out of interest how many more chart types (on the roadmap) needs migrating? We're trying to grok the size of the problem.

Additionally do you perceive this and future changes as "breaking"? Asking because @michael-s-molina is working on Superset 3.0 and technically the breaking change window has closed.

[kgabryje]

@kgabryje out of interest how many more chart types (on the roadmap) needs migrating? We're trying to grok the size of the problem.

We don't plan on implementing the feature in any more charts for now.

Additionally do you perceive this and future changes as "breaking"? Asking because @michael-s-molina is working on Superset 3.0 and technically the breaking change window has closed.

All charts except for Table and Pivot Table were ignoring d3 format specified in dataset for saved metrics. This and the previous PR implemented that behaviour in the charts that now support currencies while mimicking the behaviour of Pivot Table, where the d3format of saved metric had higher priority than the d3format selected in control panel - which means that existing charts might be affected if they used saved metrics with custom d3formats.

However, we ( @rusackas, @eschutho, @yousoph) reached consensus to invert that behaviour - d3formats from control panel will have higher priority than d3formats from dataset, in order to avoid making this feature a breaking change.

[michael-s-molina]

However, we ( @rusackas, @eschutho, @yousoph) reached consensus to invert that behaviour - d3formats from control panel will have higher priority than d3formats from dataset, in order to avoid making this feature a breaking change.

I think this is the correct approach. Thinking about hierarchy, if I define something at the control level, it should override the global dataset configuration. One thing we could do to make this smoother (if that's not the case already) is to set the default value of the control as the one defined at the dataset level, so that the user needs to explicitly change its value.

[kgabryje]

One thing we could do to make this smoother (if that's not the case already) is to set the default value of the control as the one defined at the dataset level, so that the user needs to explicitly change its value.

That wouldn't work for charts that allow more than 1 metric. Currently, the default value of format control is SMART_NUMBER, and even when you clear the select control, the value is still SMART_NUMBER instead of undefined.
The possible way to fix that is to introduce a new default value - "Dataset format", which would take d3 format from dataset and fall back to SMART_NUMBER.

[kgabryje]

The change that inverts the logic of d3 formats priority is this 1 line: https://github.com/apache/superset/pull/24594/files#diff-26b2a28ccbda108f227332667d56d83a9dd53448f1e27223cfd08c3914677a0fR38

Please keep in mind that now the custom d3 formats from datasets will remain broken in all charts except for Table until we implement the feature mentioned in post above. CC @michael-s-molina @john-bodley

[eschutho]

LGTM

[yousoph]

/testenv up

[github-actions]

@yousoph Ephemeral environment spinning up at http://35.88.68.229:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[sadpandajoe]

🏷️ preset:2023.27