-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Restyle documentation landing page and community page #24393
Conversation
…et into preset/new-docs-design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/src/pages/community.tsx
Outdated
<List.Item className="item"> | ||
<List.Item.Meta | ||
avatar={ | ||
<a className="title" href={url} target="_blank"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to add link titles for accessibility. I haven't scanned through, but there may be many other places we could improve accessibility with aria labels and such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I just added some aria labels where it made sense.
docs/src/pages/community.tsx
Outdated
.description { | ||
font-size: 14px; | ||
line-height: 20px; | ||
color: #5f5f5f; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of hard-coded colors... since we're using Emotion, we might want to provide a theme for any reusable values (type styles, colors, spacings, etc)
display: none; | ||
--ifm-font-family-base: Roboto; | ||
--ifm-footer-background-color: #173036; | ||
--ifm-footer-color: #87939a; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a comment elsewhere about using Emotion theming, but this works too ¯\_(ツ)_/¯
Maybe it's worth pulling out the other static colors into this var list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I refactored the colors to use the vars from the list :)
I can't push to this fork/branch, but the 6 new SVG files need newlines at the ends to pass linting. You can run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits, and a tip on some linting issues, but in general this looks good to me, and the site looks SOOOOO much better.
LOOKS AMAZING! |
SUMMARY
Restyles documentation landing page and community page, and adds some functionalities like a community calendar for Superset events and a newsletter section.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Old Home Page
New Home Page
Old Community Page
New Community Page
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION