-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): rollback clean comments out #24009
fix(sqllab): rollback clean comments out #24009
Conversation
@@ -106,7 +105,9 @@ const RunQueryActionButton = ({ | |||
: Button; | |||
|
|||
const sqlContent = selectedText || sql || ''; | |||
const isDisabled = cleanSqlComments(sqlContent).length === 0; | |||
const isDisabled = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe outside the scope of this PR, but I wonder if we should remove the isDisable
logic as well. Regex's scare me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #24009 +/- ##
==========================================
- Coverage 68.21% 68.12% -0.10%
==========================================
Files 1941 1941
Lines 75279 75274 -5
Branches 8166 8167 +1
==========================================
- Hits 51350 51278 -72
- Misses 21840 21907 +67
Partials 2089 2089
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SUMMARY
There's a regression caused by #23378 and #23908
This commit rollbacks the commit relates to the cleanSqlComments
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION