-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Slovenian translation update #23873
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23873 +/- ##
=======================================
Coverage 69.14% 69.14%
=======================================
Files 1946 1946
Lines 75989 75989
Branches 8479 8479
=======================================
Hits 52544 52544
Misses 21266 21266
Partials 2179 2179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
"5 minute": ["5 minute"], | ||
"5 minutes": ["5 minutes"], | ||
"5 second": ["5 second"], | ||
"5 seconds": ["5 seconds"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do so many strings in this PR seem like they're being translated back into English?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, but these are mostly time deltas for chart Advanced analytics which supports natural language (ISO 8601 durations) and time filter granularities which support natural language also.
I thought it would be confusing for users if these are translated, because natural language input has to be in English and these strings also serve as input examples. That's is why I translated those back in English (I didn't want to leave the fields empty because in the future I (or somebody else) could forget about this and translate it.
(Maybe I made some mistakes also. Sometimes it is hard to find translation string context, there are almost 4 thousand strings)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated translations with the latest master. Is there any chance this PR is merged? |
SUMMARY
This PR updates the Slovenian translation files:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Change language settings to Slovenian, check translations.
ADDITIONAL INFORMATION