fix: Database modal parameter inputs persisting after modal closed and reopened #23686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR makes the metadata parameter and engine parameter inputs controlled as the others on this modal are. Without this fix, the ace editor initial default value would not be cleared when switching between databases.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
In the following examples, Connection A actually does have engine parameters, but connection B does not.
![db_modal_before](https://user-images.githubusercontent.com/47196419/231916297-e32ab53e-3f3a-46c7-9db5-0ee459fc22ac.gif)
Before:
After:
![db_modal_after](https://user-images.githubusercontent.com/47196419/231916329-8d3d3c46-e3f1-4962-9f6f-85d81b586008.gif)
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION