Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes deprecated feature flags for 3.0 #23663

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Removes deprecated feature flags for 3.0:

  • ALLOW_DASHBOARD_DOMAIN_SHARDING
  • DISPLAY_MARKDOWN_HTML
  • FORCE_DATABASE_CONNECTIONS_SSL

This is a task of the Superset 3.0 initiative.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina force-pushed the remove-deprecated-ff-3-0 branch 2 times, most recently from 3e267db to 6dc4e46 Compare April 12, 2023 14:11
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch risk:breaking-change Issues or PRs that will introduce breaking changes labels Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #23663 (3370739) into master (b39edc1) will increase coverage by 1.78%.
The diff coverage is 0.00%.

❗ Current head 3370739 differs from pull request most recent head af2d641. Consider uploading reports for the commit af2d641 to get more accurate results

@@            Coverage Diff             @@
##           master   #23663      +/-   ##
==========================================
+ Coverage   66.30%   68.08%   +1.78%     
==========================================
  Files        1922     1922              
  Lines       74048    74046       -2     
  Branches     8104     8104              
==========================================
+ Hits        49094    50416    +1322     
+ Misses      22882    21556    -1326     
- Partials     2072     2074       +2     
Flag Coverage Δ
hive 53.18% <ø> (?)
javascript 54.13% <0.00%> (+<0.01%) ⬆️
mysql 79.21% <ø> (ø)
postgres 79.28% <ø> (-0.02%) ⬇️
presto 53.09% <ø> (?)
python 83.13% <ø> (+3.71%) ⬆️
sqlite 77.79% <ø> (ø)
unit 53.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/superset-ui-core/src/components/SafeMarkdown.tsx 85.71% <0.00%> (+19.04%) ⬆️
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...end/src/features/databases/DatabaseModal/index.tsx 45.36% <ø> (-0.12%) ⬇️
superset-frontend/src/utils/hostNamesConfig.js 73.33% <ø> (ø)
superset/config.py 91.86% <ø> (ø)

... and 95 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina force-pushed the remove-deprecated-ff-3-0 branch 2 times, most recently from fc374dd to e207383 Compare April 12, 2023 20:42
@michael-s-molina michael-s-molina merged commit 6234888 into apache:master Apr 17, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants