chore: Removes the UX_BETA feature flag #23651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
risk:breaking-change
villebro
approved these changes
Apr 11, 2023
| @@ -459,7 +459,6 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]: | |||
| # Allow users to export full CSV of table viz type. | |||
| # This could cause the server to run out of memory or compute. | |||
| "ALLOW_FULL_CSV_EXPORT": False, | |||
| "UX_BETA": False, | |||
There was a problem hiding this comment.
Note for future feature flag removals: we should always try to enable FFs by default a good time in advance of removal.
Codecov Report
@@ Coverage Diff @@
## master #23651 +/- ##
==========================================
- Coverage 68.08% 68.08% -0.01%
==========================================
Files 1920 1920
Lines 73990 73990
Branches 8092 8091 -1
==========================================
- Hits 50379 50374 -5
- Misses 21540 21547 +7
+ Partials 2071 2069 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
michael-s-molina
changed the title
michael-s-molina
force-pushed
the
remove-ux-beta-ff
branch
from
caef461
to
fc97277
Compare
michael-s-molina
force-pushed
the
remove-ux-beta-ff
branch
from
fc97277
to
1a552de
Compare
sebastianliebscher
pushed a commit
to sebastianliebscher/superset
that referenced
this pull request
Apr 28, 2023
michael-s-molina
removed
the
v3.0
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removes the
UX_BETAfeature flag.This is a task of the Superset 3.0 initiative.
ADDITIONAL INFORMATION