-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Makes "Add to dashboard" in Save chart modal paginated #23634
feat: Makes "Add to dashboard" in Save chart modal paginated #23634
Conversation
@jinghua-qa Can you help me and make sure there's no regression? |
Codecov Report
@@ Coverage Diff @@
## master #23634 +/- ##
==========================================
- Coverage 67.71% 67.70% -0.02%
==========================================
Files 1918 1918
Lines 74157 74151 -6
Branches 8053 8047 -6
==========================================
- Hits 50219 50204 -15
- Misses 21885 21894 +9
Partials 2053 2053
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@geido Ephemeral environment spinning up at http://54.213.228.129:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. It would be good to have QA confirm as well. Thanks!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Changes "Add to dashboard" in Save chart modal to use the async Select with pagination enabled.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2023-04-10.at.11.46.13.mov
TESTING INSTRUCTIONS
Make sure there's no regression and that the "Add to dashboard" Select loads the values using paginated queries.
ADDITIONAL INFORMATION