-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update log message for ALERT_REPORTS_NOTIFICATION_DRY_RUN #23604
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23604 +/- ##
==========================================
- Coverage 67.72% 67.70% -0.03%
==========================================
Files 1916 1918 +2
Lines 74051 74133 +82
Branches 8040 8052 +12
==========================================
+ Hits 50153 50193 +40
- Misses 21850 21887 +37
- Partials 2048 2053 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset/reports/commands/execute.py
Outdated
self._report_schedule.name, | ||
recipient.recipient_config_json, | ||
app.config["ALERT_REPORTS_NOTIFICATION_DRY_RUN"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this not produce True is enabled, set it to False to send notifications.
, as that's the value of the config param, not it's name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I thought I pushed a fix for that 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... I pushed to the wrong remote. Fixed
532a5f8
to
f41e26d
Compare
SUMMARY
Let's make it clearer that dry run is enabled. Many people interpret the current message to mean that the notification was sent.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION