-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Changes the inputs of native filters modal to have the same width #23477
chore: Changes the inputs of native filters modal to have the same width #23477
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23477 +/- ##
=======================================
Coverage 67.64% 67.65%
=======================================
Files 1908 1910 +2
Lines 73739 73746 +7
Branches 7988 7987 -1
=======================================
+ Hits 49879 49891 +12
Misses 21814 21814
+ Partials 2046 2041 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one last optional nit. And thanks for doing this - I've been meaning to do something about it, and I'm very happy you actually did something about it! 🎉
@@ -59,7 +60,7 @@ const DefaultValue: FC<DefaultValueProps> = ({ | |||
) : ( | |||
<SuperChart | |||
height={32} | |||
width={formFilter?.filterType === 'filter_time' ? 350 : 250} | |||
width={formFilter?.filterType === 'filter_time' ? 350 : INPUT_WIDTH} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit of a bycatch - it could be nice to move 350
into constants
, too, maybe as TIME_FILTER_INPUT_WIDTH
.
…dth (apache#23477) (cherry picked from commit 21578f7)
SUMMARY
Changes the inputs of native filters modal to have the same width.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2023-03-23.at.19.01.14.mov
Screen.Recording.2023-03-23.at.18.55.26.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION