Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Flask-AppBuilder to 4.2.0 #22580

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jan 3, 2023

SUMMARY

Bumps Flask-AppBuilder to 4.2.0 which includes dpgaspar/Flask-AppBuilder#1971 et al. which #22413 plans to leverage from a performance standpoint.

pip-compile-multi --upgrade-package=flask-appbuilder

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley changed the title chore: Bump FAB to 4.2.0 chore: Bump Flask-AppBuilder to 4.2.0 Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #22580 (b5171af) into master (ebaad10) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22580      +/-   ##
==========================================
- Coverage   67.00%   66.90%   -0.10%     
==========================================
  Files        1859     1859              
  Lines       71019    71019              
  Branches     7766     7766              
==========================================
- Hits        47587    47518      -69     
- Misses      21410    21479      +69     
  Partials     2022     2022              
Flag Coverage Δ
hive ?
mysql 77.99% <ø> (ø)
postgres 78.06% <ø> (ø)
presto 52.36% <ø> (ø)
python 81.12% <ø> (-0.21%) ⬇️
sqlite 76.44% <ø> (ø)
unit 51.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 71.25% <0.00%> (-16.15%) ⬇️
superset/db_engine_specs/base.py 88.95% <0.00%> (-0.32%) ⬇️
superset/connectors/sqla/models.py 89.16% <0.00%> (-0.20%) ⬇️
superset/utils/core.py 90.78% <0.00%> (-0.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit 0908fd2 into apache:master Jan 11, 2023
@john-bodley john-bodley deleted the john-bodley--bump-fab branch January 16, 2023 17:52
jinghua-qa added a commit to preset-io/superset that referenced this pull request Jan 27, 2023
AnushaErrabelli added a commit to preset-io/superset that referenced this pull request Jan 30, 2023
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Feb 2, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants