Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Programmatically open "more filters" dropdown in Horizontal Filter Bar #22276

Merged
merged 14 commits into from
Dec 2, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use FAST_DEBOUNCE
geido committed Dec 1, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 5a11835dca7a92599434e61a3a6ad1cd29f04ab0
Original file line number Diff line number Diff line change
@@ -44,6 +44,7 @@ import { waitForAsyncData } from 'src/middleware/asyncEvent';
import { ClientErrorObject } from 'src/utils/getClientErrorObject';
import { FilterBarOrientation, RootState } from 'src/dashboard/types';
import { onFiltersRefreshSuccess } from 'src/dashboard/actions/dashboardState';
import { FAST_DEBOUNCE } from 'src/constants';
import { dispatchHoverAction, dispatchFocusAction } from './utils';
import { FilterControlProps } from './types';
import { getFormData } from '../../utils';
@@ -214,7 +215,7 @@ const FilterValue: React.FC<FilterControlProps> = ({
if (focusedFilterId && focusedFilterId === filter.id) {
setTimeout(() => {
inputRef?.current?.focus();
}, 100);
}, FAST_DEBOUNCE);
}
}, [inputRef, focusedFilterId, filter.id]);

Original file line number Diff line number Diff line change
@@ -24,6 +24,7 @@ import {
setHoveredNativeFilter,
unsetHoveredNativeFilter,
} from 'src/dashboard/actions/nativeFilters';
import { FAST_DEBOUNCE } from 'src/constants';

export const dispatchHoverAction = debounce(
(dispatch: Dispatch<any>, id?: string) => {
@@ -33,7 +34,7 @@ export const dispatchHoverAction = debounce(
dispatch(unsetHoveredNativeFilter());
}
},
300,
FAST_DEBOUNCE,
);

export const dispatchFocusAction = debounce(
@@ -44,5 +45,5 @@ export const dispatchFocusAction = debounce(
dispatch(unsetFocusedNativeFilter());
}
},
300,
FAST_DEBOUNCE,
);