refactor: restructure shared-contrls modules #22224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The original goal of this PR is that the
XAxisSortControl
should be moved intoshared-controls
modules(refer to PR). So, do a refactor in this part.legacySortBy.tsx
shared-controls
is declared as a module and creates aindex.ts
in it.shared-controls
.emitFilterControl.ts
to thecustomControls.ts
, the goal is that this file should contain more custom controls in the future.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/a
TESTING INSTRUCTIONS
should pass all CI steps.
ADDITIONAL INFORMATION